Add WAL write duration metric #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wangweizhen <hawking.rei@gmail.com>
|
@yiwu-arbug PTAL |
6 tasks
yiwu-arbug
reviewed
Mar 9, 2020
| @@ -1147,6 +1147,7 @@ Status DBImpl::WriteToWAL(const WriteThread::WriteGroup& write_group, | |||
| // Same holds for all in the batch group | |||
| size_t write_with_wal = 0; | |||
| WriteBatch* to_be_cached_state = nullptr; | |||
| StopWatch write_sw(env_, stats_, DB_WRITE_WAL_TIME); | |||
There was a problem hiding this comment.
Let's add the same stopwatch to ConcurrentWriteToWAL as well.
Signed-off-by: Wangweizhen <hawking.rei@gmail.com>
yiwu-arbug
approved these changes
Mar 9, 2020
yiwu-arbug
pushed a commit
that referenced
this pull request
Mar 20, 2020
Add WAL write duration metric UCP [facebook#5751](tikv/tikv#6541) Signed-off-by: Wangweizhen <hawking.rei@gmail.com>
tabokie
pushed a commit
to tabokie/rocksdb
that referenced
this pull request
May 12, 2022
Add WAL write duration metric UCP tikv/tikv#6541 Signed-off-by: Wangweizhen <hawking.rei@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
pushed a commit
that referenced
this pull request
May 12, 2022
Add WAL write duration metric UCP tikv/tikv#6541 Signed-off-by: Wangweizhen <hawking.rei@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com>
v01dstar
pushed a commit
to v01dstar/rocksdb
that referenced
this pull request
Sep 24, 2024
Add WAL write duration metric UCP tikv/tikv#6541 Signed-off-by: Wangweizhen <hawking.rei@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com> Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
Merged
v01dstar
pushed a commit
to v01dstar/rocksdb
that referenced
this pull request
Sep 27, 2024
Add WAL write duration metric UCP tikv/tikv#6541 Signed-off-by: Wangweizhen <hawking.rei@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com> Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add WAL write duration metric
UCP #5751
Signed-off-by: Wangweizhen hawking.rei@gmail.com